ENH extra smoothing in prepsf moments #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckermr
changed the title
|
@esheldon It appears we will want this so I cleaned up the PR. This feature should have a minor version bump so I bumped to 2.1 from 2.0.6. |
esheldon
requested changes
Jun 29, 2022
|
A point of discussion: if the inverse pixel variance weighting isn't working well, do we want to include it? |
I am on the fence. I guess if we understood why things are or are not working we'd be in a better spot to decide. |
|
I removed the pixel weighting approach. |
|
OK @esheldon This is ready for another look! |
esheldon
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A draft implementation of this.
TODO: